Cross build laika-sbt for sbt 2#774
Open
tanishiking wants to merge 1 commit into
Open
Conversation
tanishiking
changed the title
tanishiking
commented
Jun 29, 2026
| logLevel = MessageFilter.Warning | ||
| ) | ||
|
|
||
| private def unapply(conf: LaikaConfig) = conf |
Author
There was a problem hiding this comment.
unused, removed for suppress warning in Scala3.
| Laika / clean := Tasks.clean.value, | ||
| laikaSite / mappings := Def.sequential(Tasks.site, Tasks.mappings).value | ||
| ) :+ (cleanFiles += (Laika / target).value) | ||
| @nowarn("msg=unused import") |
Author
There was a problem hiding this comment.
For sbtcompat.PluginCompat.* in Scala3.
fix typelevel#773 - Exclude all laika-sbt tasks from sbt 2 caching with `Def.uncached`. - Adapt to sbt2 API changes using https://github.com/sbt/sbt2-compat if you don't like adding dependency, we can define small set of PluginCompat. - Run the plugin build and tests in CI with sbt 2, Scala 3, and Java 17. - Set `Laika / target` explicitly in each scripted project `build.sbt` so scripted tests work across sbt 1 and 2 target directory. Depends on upstream sbt change sbt/sbt#9377
tanishiking
marked this pull request as ready for review
June 29, 2026 08:41
armanbilge
self-requested a review
July 1, 2026 16:57
reardonj
reviewed
Jul 22, 2026
reardonj
left a comment
reardonj
left a comment
There was a problem hiding this comment.
This looks pretty reasonable. I'm not familiar with the CI setup stuff enough to comment on it.
|
|
||
| enablePlugins(LaikaPlugin) | ||
|
|
||
| Laika / target := baseDirectory.value / "target" / "docs" |
There was a problem hiding this comment.
Did this have to be added due to sbt2 changes the target directory setup?
| else Some(8) | ||
| }, | ||
| // Scaladoc 3 cannot currently resolve some TASTy from sbt 2 transitive dependencies. | ||
| // https://github.com/scala/scala3/issues/18487 |
There was a problem hiding this comment.
I see you fixed this bug. I guess we are stuck until at least 3.9 to make use of it though?
| // TODO: Re-enable MiMa for sbt 2 once a previous sbt 2 plugin artifact exists. | ||
| // The sbt 2 / Scala 3 plugin artifact did not exist in previous Laika releases, | ||
| // so MiMa cannot compare against a missing baseline. | ||
| mimaPreviousArtifacts := { |
There was a problem hiding this comment.
I don't suppose there is a nicer way to do this @armanbilge ?
| Seq( | ||
| Laika / sourceDirectories := Seq(sourceDirectory.value / "docs"), | ||
| Laika / excludeFilter := HiddenFileFilter, | ||
| laikaInputs := Def.uncached(Settings.defaultInputs.value), |
There was a problem hiding this comment.
Do these need to be uncached or is this just for ease of migration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on upstream sbt change sbt/sbt#9377,
we need to wait until sbt 2.0.12.0.1 is released with that fix.close #773
Def.uncached.Laika / targetexplicitly in each scripted projectbuild.sbtso scripted tests work across sbt 1 and 2 target directory.Depends on upstream sbt change sbt/sbt#9377